feat: preformat dns qname to compatible with DNS type 65 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zephyruso
force-pushed
the
preformat-dns
branch
2 times, most recently
from
cb5827b
to
d473c45
Compare
Zephyruso
force-pushed
the
preformat-dns
branch
from
d473c45
to
1c54357
Compare
Zephyruso
changed the title
我看到这似乎是dns的一种合法的类型即type 65 HTTPS https://datatracker.ietf.org/doc/rfc9460/?include_text=1, 并不是美团问题，而是在处理HTTPS类型的dns中没有正确的将hostname匹配出来而是带着https直接去匹配了导致无法匹配dns路由 |
|
感谢你的贡献，根据截图，qtype 是 A，此时应当不携带 https:// 这是 meituan 的问题，dae 不应该改变 dns 的行为 |
确实 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Preformat the name in DNS requests routing to be compatible with DNS type 65
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result
Before:
After: