Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: cache NXDomain and reject with 0.0.0.0/:: #63

Merged
merged 3 commits into from
Apr 29, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Apr 29, 2023

Background

  1. When "ipversion_prefer" is on and the domain being looked up does not have an AAAA record, NXDomain was not cached and a new lookup was required each time. It cost much time.
  2. Empty answer is NXDomain, which will not be cached by downstream domain server implementation. And a new lookup would be sent to dae each time. It cost many connections/packets.

Modification

  1. Cache NXDomain result and non-A/AAAA result.
  2. Reject with 0.0.0.0/:: instead of NXDomain.

piyoki
piyoki previously approved these changes Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants