fix: "Stuck on Verifying..." #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
previously approved these changes
Feb 22, 2022
camrein
requested changes
Feb 23, 2022
| }".TrimStart(); | ||
| var documentItem = CreateTestDocument(source); | ||
| client.OpenDocument(documentItem); | ||
| Thread.Sleep(5000); |
There was a problem hiding this comment.
Prefer using await Task.Delay(5_000); here
| @@ -100,11 +100,11 @@ public class DafnyProgramVerifier : IProgramVerifier { | |||
| // However, the cancelling a verification is currently not possible since it blocks a text document | |||
There was a problem hiding this comment.
I think we can remove this comment now
|
Just in case you're waiting for the approval: I think you didn't push your latest changes. 😄 |
|
Indeed, I did not, because there is still a problem in Boogie where counter-examples are not reported correctly anymore. I'll be waiting on Boogie to be compatible with Dafny again to solve this issue. |
MikaelMayer
commented
Mar 1, 2022
camrein
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds no new operational code because the fix is in Boogie:
boogie-org/boogie#491
This fix has been merged, and this PR bumps the Boogie version, so the test included should now pass.
This tests asks the verifier to do something hard, and cancels verification by performing a change on the text.
Until this PR, the verifier is stuck verifying, but with the fix above, it will cancel verification, kill zombie processes, and continue smoothly