Build DafnyRuntime for netstandard2.0 and net452 instead of net6.0 #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
previously approved these changes
Nov 14, 2022
keyboardDrummer
previously approved these changes
Nov 15, 2022
cpitclaudel
previously approved these changes
Nov 15, 2022
net452 only supports up to netstandard1.2, and that version of the standard is missing some APIs we need. Also removed the <TargetFramework>net6.0</TargetFramework> definition from Directory.Build.props, which is most likely the reason for the previous “project.assets.json doesn't have a target for 'netstandard2.0’” errors.
robin-aws
dismissed stale reviews from cpitclaudel and keyboardDrummer
via
e2d3880
robin-aws
changed the title
cpitclaudel
approved these changes
Nov 17, 2022
| @@ -127,21 +127,23 @@ def zipify_path(fpath): | |||
| """Zip entries always use '/' as the path separator.""" | |||
| return fpath.replace(os.path.sep, '/') | |||
|
|
|||
| def run_publish(self, project): | |||
| def run_publish(self, project, framework = None): | |||
There was a problem hiding this comment.
Suggested change
| def run_publish(self, project, framework = None): | |
| def run_publish(self, project, framework=None): |
Comment on lines
+138
to
+140
| otherArgs = [] | ||
| if framework: | ||
| otherArgs += ["-f", framework] |
There was a problem hiding this comment.
Suggested change
| otherArgs = [] | |
| if framework: | |
| otherArgs += ["-f", framework] | |
| framework_args = ["-f", framework] if framework else [] |
| "-o", self.buildDirectory, | ||
| "-r", self.target, | ||
| "--self-contained", | ||
| "-c", "Release"], env=env) | ||
| "-c", "Release"] + otherArgs, env=env) |
There was a problem hiding this comment.
Suggested change
| "-c", "Release"] + otherArgs, env=env) | |
| "-c", "Release", *framework_args], env=env) |
There was a problem hiding this comment.
Ah thank you, I thought I recalled something like that. If the CI has to be rerun anyway I'll apply this (and the one above) :)
robin-aws
added a commit
to robin-aws/dafny
that referenced
this pull request
Nov 17, 2022
Since we can’t use the latter on .NET Standard or .NET Framework 4.5.2 Thanks, jerk who wrote for dafny-lang#2795 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2779.
Another attempt after the previous attempt (#2604) had to be reverted (#2710). I tried this with a fresh clone and didn't run into the Rider problem described in #2710 - I'm relatively confident the
<TargetFramework>net6.0</TargetFramework>I've removed fromDirectory.Build.propswas to blame, and/or just needing to thoroughly cleanbinandobjdirectories.Note that I am partially relying on post-hoc testing of the nightly build packages after this is merged, to ensure the
net452build actually works on Windows.Note also that the packaging warnings I refer to in one of the commit messages are an existing, orthogonal issue: #3069
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.