-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a release script #2848
Merged
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6bea8ee
feat: Add a release script
cpitclaudel 97ab685
Update docs/dev/news/README.md
cpitclaudel 329125b
Mikael's feedback
cpitclaudel 46ac8b9
Describe format of output and test it
cpitclaudel c71ae40
Rename prefix and suffix to main and identifier
cpitclaudel 51d06f5
Remove newlines before links
cpitclaudel 8297bec
Better support for multiline entries
cpitclaudel 3e78fd1
Merge remote-tracking branch 'origin/master' into cpitclaudel_auto-re…
cpitclaudel 4582480
Move release entry from 8.9 to latest
cpitclaudel dee1482
Remove added sentence in RELEASE.md
cpitclaudel 30303ab
Pacify pylint
cpitclaudel 256db39
Check for newlines in trimmed contents
cpitclaudel f628020
Add tests
cpitclaudel 14ade58
Update docs/dev/news/README.md
cpitclaudel e49a42b
Delete news before commit
cpitclaudel 76855a8
Merge branch 'master' into cpitclaudel_auto-release
cpitclaudel 69d0497
Merge remote-tracking branch 'origin/master' into cpitclaudel_auto-re…
cpitclaudel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a stronger comment that this file is no longer used as part of the release process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a user-facing file, though, so should we add this type of comments there?
Maybe as a comment that doesn't get rendered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add a comment about the release process here, but I like the idea of also redirecting users to the folder where the fragments are so that they can see what to expect in the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I missed the fact that the script is still updating this file, I thought it was going to be frozen in this state forever more. Nevermind. :)