Do not fail the deep test check on in progress runs #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this mean that the tests always run as long as there is a deep test in progress? You should still make sure that the previous run passed. |
You're right, thanks! Updated the code. |
fabiomadge
previously approved these changes
Jan 16, 2023
| core.setFailed(`Last run of ${runFilterDesc} did not succeed: ${run.html_url}`) | ||
| return |
There was a problem hiding this comment.
Can you pull that out?
There was a problem hiding this comment.
I will, but I wonder whether it's worth the extra build trip ^,^
fabiomadge
approved these changes
Jan 17, 2023
davidcok
pushed a commit
to davidcok/dafny
that referenced
this pull request
Jan 18, 2023
If there is a deep test check, and multiple runs qualify for that check, but the most recent run in still in progress, do not fail the check on that run, but instead look at the first not in progress run. Also add a missing return statement so we don't get don't confusing error reporting like this: <img width="1011" alt="image" src="https://user-images.githubusercontent.com/3121201/212307198-f0041b1c-e6dc-4852-ab75-38816122eeff.png"> <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
davidcok
pushed a commit
to davidcok/dafny
that referenced
this pull request
Jan 20, 2023
If there is a deep test check, and multiple runs qualify for that check, but the most recent run in still in progress, do not fail the check on that run, but instead look at the first not in progress run. Also add a missing return statement so we don't get don't confusing error reporting like this: <img width="1011" alt="image" src="https://user-images.githubusercontent.com/3121201/212307198-f0041b1c-e6dc-4852-ab75-38816122eeff.png"> <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a deep test check, and multiple runs qualify for that check, but the most recent run in still in progress, do not fail the check on that run, but instead look at the first not in progress run.
Also add a missing return statement so we don't get don't confusing error reporting like this:
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.