feat: Semantics for dots in {:extern} module names in Python
#3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
reviewed
May 2, 2023
There was a problem hiding this comment.
Definitely an improvement and the implementation LGTM. Does this fix #2963?
How about an update to docs/DafnyRef/integration-py/IntegrationPython.md?
What happens if you also include an Nested.Library.Child module? Is it impossible since then we'd want Nested/Library/__init__.py instead?
| @@ -866,7 +866,7 @@ private record TargetPaths(string Directory, string Filename) { | |||
| var callToMainTree = new ConcreteSyntaxTree(); | |||
| string baseName = Path.GetFileNameWithoutExtension(dafnyProgramName); | |||
| compiler.EmitCallToMain(mainMethod, baseName, callToMainTree); | |||
| callToMain = callToMainTree.ToString(); // assume there aren't multiple files just to call main | |||
| callToMain = callToMainTree.MakeString(compiler.TargetIndentSize); // assume there aren't multiple files just to call main | |||
|
Yes, this only allows for definitions at the leafs, which seems to be the way to structure modules in Python anyway. |
robin-aws
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2963.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.