Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error correction in the parser #4411

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

keyboardDrummer
Copy link
Member

Fixes #4408

Testing

Did not add a test since we need a more general mechanism to test the cloner code that's currently only run by the language server, instead of single tests that only cover a single situation.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah thank you very much, I hit this one literally every day.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) August 14, 2023 10:38
@keyboardDrummer keyboardDrummer merged commit a5c6a24 into dafny-lang:master Aug 14, 2023
18 checks passed
keyboardDrummer added a commit to keyboardDrummer/dafny that referenced this pull request Sep 15, 2023
Fixes dafny-lang#4408

### Testing
Did not add a test since we need a more general mechanism to test the
cloner code that's currently only run by the language server, instead of
single tests that only cover a single situation.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer added a commit that referenced this pull request Sep 19, 2023
Fixes #4408

### Testing
Did not add a test since we need a more general mechanism to test the
cloner code that's currently only run by the language server, instead of
single tests that only cover a single situation.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser error on IDE without any indication where it occurred
2 participants