fix: Escape tallies temporary file path properly #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4755 broke the nightly build because I neglected to escape a string literal properly. Works just fine as long as your directory separator is
/, but then Windows had to go and be all different. :)I attempted to use
EmitStringLiteralto escape correctly, but it turns out that this still tried to translate Dafny\Uunicode escape sequences in a windows path likeC:\Users\.... I suspect there might be a bug lurking there too but didn't want to block fixing the nightly build on it.How has this been tested?
Existing tests with
run-deep-tests.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.