Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix crash for lookup of non-existing member in new resolver #4955

Merged
merged 3 commits into from
Jan 10, 2024
Merged

fix: Fix crash for lookup of non-existing member in new resolver #4955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44384e8
fix: Fix crash for lookup of non-existing member in new resolver
RustanLeino Jan 9, 2024
565c6ab
Add release notes
RustanLeino Jan 9, 2024
6f37b66
Merge branch 'master' into issue-4953
RustanLeino Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/DafnyCore/Resolver/PreType/PreTypeResolve.Expressions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,8 @@ private void ConstrainOperandTypes(IToken tok, string opString, Expression e0, E
if (receiverDecl is TopLevelDeclWithMembers receiverDeclWithMembers) {
// TODO: does this case need to do something like this? var cd = ctype?.AsTopLevelTypeWithMembersBypassInternalSynonym;

if (!resolver.GetClassMembers(receiverDeclWithMembers).TryGetValue(memberName, out var member)) {
var members = resolver.GetClassMembers(receiverDeclWithMembers);
if (members == null || !members.TryGetValue(memberName, out var member)) {
if (!reportErrorOnMissingMember) {
// don't report any error
} else if (memberName == "_ctor") {
Expand Down
17 changes: 17 additions & 0 deletions Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-4953.dfy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// RUN: %testDafnyForEachResolver "%s" --expect-exit-code=2

// The lookup of a non-existing member once caused a crash in the new resolver.

function Foo(): (result: seq<int>)
ensures result.NonExistingMember

function Bar(formal: seq<int>): int
requires formal.NonExistingMember

method Zap(i: seq<int>) returns (o: seq<int>) {
var local: seq<int> := [];

var a := i.NonExistingMember;
var b := o.NonExistingMember;
var c := local.NonExistingMember;
}
6 changes: 6 additions & 0 deletions Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-4953.dfy.expect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
git-issue-4953.dfy(6,17): Error: type seq<int> does not have a member NonExistingMember
git-issue-4953.dfy(9,18): Error: type seq<int> does not have a member NonExistingMember
git-issue-4953.dfy(14,13): Error: type seq<int> does not have a member NonExistingMember
git-issue-4953.dfy(15,13): Error: type seq<int> does not have a member NonExistingMember
git-issue-4953.dfy(16,17): Error: type seq<int> does not have a member NonExistingMember
5 resolution/type errors detected in git-issue-4953.dfy
6 changes: 6 additions & 0 deletions .../IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-4953.dfy.refresh.expect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
git-issue-4953.dfy(6,17): Error: member 'NonExistingMember' does not exist in type 'seq'
git-issue-4953.dfy(9,18): Error: member 'NonExistingMember' does not exist in type 'seq'
git-issue-4953.dfy(14,13): Error: member 'NonExistingMember' does not exist in type 'seq'
git-issue-4953.dfy(15,13): Error: member 'NonExistingMember' does not exist in type 'seq'
git-issue-4953.dfy(16,17): Error: member 'NonExistingMember' does not exist in type 'seq'
5 resolution/type errors detected in git-issue-4953.dfy
1 change: 1 addition & 0 deletions docs/dev/news/4955.fix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix crash for lookup of non-existing member in new resolver
Loading