Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent verification as tests UI from becoming unresponsive #421

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/ui/verificationSymbolStatusView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,22 +91,25 @@ export default class VerificationSymbolStatusView {
const runningItems: TestItem[] = [];
let outerResolve: () => void;
await this.noRunCreationInProgress;
this.noRunCreationInProgress = new Promise((resolve) => {
outerResolve = resolve;
});

const runs = items.map(item => this.languageClient.runVerification({ position: item.range!.start, textDocument: { uri: item.uri!.toString() } }));
for(const index in runs) {
const success = await runs[index];
if(success) {
runningItems.push(items[index]);
try {
this.noRunCreationInProgress = new Promise((resolve) => {
outerResolve = resolve;
});

const runs = items.map(item => this.languageClient.runVerification({ position: item.range!.start, textDocument: { uri: item.uri!.toString() } }));
for(const index in runs) {
const success = await runs[index];
if(success) {
runningItems.push(items[index]);
}
}
}

if(runningItems.length > 0) {
this.createRun(runningItems);
if(runningItems.length > 0) {
this.createRun(runningItems);
}
} finally {
outerResolve!();
}
outerResolve!();
}, true);
return controller;
}
Expand Down
Loading