-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make status bar forward compatible with upcoming Dafny release #432
Make status bar forward compatible with upcoming Dafny release #432
Conversation
I just tested this branch on Dafny 3.7, on this simple example:
it's stuck on "Verifying" both on the status bar and the gutter icons. The arguments are
On 3.8.0, it's stuck on "Verified 0/1, verifying Test" On 3.9.0 it correctly displays "assertion might not hold" on the "false" and gutter icons respond correctly |
I see that the same problem occurs on the VSCode extension master for Dafny 3.7 and 3.8. Looking at what the server sends last for 3.7:
This is not telling the IDE to display anything more than "Verifying", so no IDE fix will make it backwards compatible with this older server version. For the gutter icons, the server seems to be using an older API version, since the numbers don't match with what I'm used to from the latest gutter icon API.
On 3.8 I also see this in the logs:
Maybe we're testing 3.7 and 3.8 against the wrong version of Z3. However, it seems that the status bar is correctly responding to the information it's getting from the server, so I suggest we consider this test 'passed', even though something is wrong with the server we're testing against and that doesn't give us the right end-to-end behavior. |
Changes
VerificationSymbolStatusView
update the status bar, but let the status bar work independently, so the status bar remains up to date even if 'verification as tests' is turned off.Testing