Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return None instead of False for load_user's except #1001

Merged
merged 2 commits into from
Mar 10, 2023
Merged

return None instead of False for load_user's except #1001

merged 2 commits into from
Mar 10, 2023

Conversation

aaronhelton
Copy link
Member

Fixes #1000

@aaronhelton
Copy link
Member Author

To test: set DLX_REST_DEV="True", run application, and login. Then change environment by unsetting DLX_REST_DEV and setting DLX_REST_QAT="True". Accessing the application now should take you to a login page, not an internal server error.

@aaronhelton aaronhelton merged commit 13cb040 into master Mar 10, 2023
@aaronhelton aaronhelton deleted the fix-user-session branch March 10, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbukhari jbukhari jbukhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1st bug fixes (patch release)
Development

Successfully merging this pull request may close these issues.

Expired sessions raise AttributeError on current_user object
2 participants
@aaronhelton @jbukhari