Make msvc compile by adding the ifdefs back in gelu_backward, fixes k…

…arpathy#200
dagelf · Apr 22, 2024 · 4056446 · 4056446
1 parent 451c1a4
commit 4056446
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/train_gpt2.c b/train_gpt2.c
@@ -364,8 +364,10 @@ void gelu_forward(float* out, float* inp, int N) {
 }
 
 // we want to use -Ofast optimization, but sadly GeLU breaks, so disable this flag just for it (#168)
-#pragma float_control(precise, on, push) // On msvc /fp:fast is a lot faster, but the expf inside coshf breaks the model
+#pragma float_control(precise, on, push)
+#if defined(__GNUC__) && !defined(__clang__)
 __attribute__((optimize("no-finite-math-only"))) // same for gcc -Ofast
+#endif
 void gelu_backward(float* dinp, float* inp, float* dout, int N) {
     for (int i = 0; i < N; i++) {
         float x = inp[i];