Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.10.2 #413

Merged
merged 32 commits into from
Mar 19, 2023
Merged

v1.10.2 #413

merged 32 commits into from
Mar 19, 2023

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Mar 18, 2023

* fix bug that parameter modal is not shown

* Improve parameter parsing function to handle a parameter that contains multiple lines

* fix bugs

* fix bugs
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Patch coverage: 76.45% and project coverage change: -0.94 ⚠️

Comparison is base (da30895) 82.18% compared to head (5d9c0ea) 81.25%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   82.18%   81.25%   -0.94%     
==========================================
  Files          30       30              
  Lines        3211     3345     +134     
==========================================
+ Hits         2639     2718      +79     
- Misses        434      488      +54     
- Partials      138      139       +1     
Impacted Files Coverage Δ
internal/admin/http.go 79.22% <0.00%> (-2.12%) ⬇️
internal/dag/context.go 0.00% <0.00%> (ø)
internal/database/database.go 82.40% <0.00%> (+0.75%) ⬆️
internal/utils/utils.go 62.09% <35.78%> (-15.55%) ⬇️
internal/runner/entry.go 68.18% <50.00%> (ø)
internal/agent/agent.go 78.15% <79.54%> (-1.01%) ⬇️
internal/dag/builder.go 76.55% <83.07%> (+1.01%) ⬆️
internal/dag/loader.go 79.13% <84.74%> (+2.54%) ⬆️
cmd/commands.go 94.14% <88.49%> (-1.00%) ⬇️
internal/dag/dag.go 91.66% <89.13%> (+8.10%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yohamta yohamta marked this pull request as ready for review March 19, 2023 13:29
@yohamta yohamta merged commit d0b5465 into main Mar 19, 2023
@yohamta yohamta deleted the develop branch March 19, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI to input multiple line of parameter
2 participants