Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DAG store #478

Merged
merged 5 commits into from
Sep 10, 2023
Merged

Implement DAG store #478

merged 5 commits into from
Sep 10, 2023

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Sep 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 81.11% and project coverage change: -0.15% ⚠️

Comparison is base (a901027) 78.58% compared to head (e72eb35) 78.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   78.58%   78.44%   -0.15%     
==========================================
  Files          38       38              
  Lines        3432     3414      -18     
==========================================
- Hits         2697     2678      -19     
- Misses        599      600       +1     
  Partials      136      136              
Files Changed Coverage Δ
internal/engine/engine.go 71.09% <73.17%> (-4.21%) ⬇️
internal/engine/factory.go 84.21% <81.25%> (-15.79%) ⬇️
internal/persistence/jsondb/database.go 72.65% <88.88%> (+1.39%) ⬆️
cmd/dry.go 100.00% <100.00%> (ø)
cmd/restart.go 93.10% <100.00%> (ø)
cmd/retry.go 100.00% <100.00%> (ø)
cmd/start.go 100.00% <100.00%> (ø)
cmd/status.go 100.00% <100.00%> (ø)
cmd/stop.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yohamta yohamta merged commit 098efa9 into main Sep 10, 2023
4 checks passed
@yohamta yohamta deleted the impl-dagstore branch September 10, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant