Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command flag duplication issue #522

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Fix command flag duplication issue #522

merged 2 commits into from
Jan 7, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Jan 7, 2024

Resolve #521

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cc0c36e) 72.76% compared to head (8e7016f) 72.75%.
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/start_all.go 0.00% 5 Missing and 1 partial ⚠️
cmd/root.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   72.76%   72.75%   -0.02%     
==========================================
  Files          43       43              
  Lines        3705     3736      +31     
==========================================
+ Hits         2696     2718      +22     
- Misses        870      878       +8     
- Partials      139      140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yohamta yohamta merged commit c9435a8 into main Jan 7, 2024
3 checks passed
@yohamta yohamta deleted the cmdflagissue branch January 7, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Change server host and port
1 participant