Fix issue with socket length > 108 due to long task names #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zph
force-pushed
the
zh-fix-socket-length
branch
5 times, most recently
from
3395099
to
4b6aafb
Compare
Ensures that we truncate task names to no more than 60 chars so they don't exceed the total length limit of 108 that's impose by unix. Fixes: dagu-org#395
zph
force-pushed
the
zh-fix-socket-length
branch
from
4b6aafb
to
d1b98b4
Compare
|
Hi @zph, ✨✨✨LGTM✨✨✨, thank you very much for the amazing PR! |
yohamta
approved these changes
Jun 27, 2024
|
@yohamta 🤩 you're welcome! TY very much for creating this minimalist airflow! I'm happy to contribute back :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we truncate task names to no more than 60 chars so they don't exceed the total length limit of 108 that's impose by unix.
Fixes: #395