Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permutecomps/permutecomps! #66

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add permutecomps/permutecomps! #66

merged 4 commits into from
Aug 22, 2024

Conversation

dahong67
Copy link
Owner

New function for permuting the components in a CPD.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.70%. Comparing base (efae337) to head (72e3091).
Report is 1 commits behind head on master.

Files Patch % Lines
src/cpd.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #66      +/-   ##
===========================================
- Coverage   100.00%   97.70%   -2.30%     
===========================================
  Files           13       11       -2     
  Lines          369      349      -20     
===========================================
- Hits           369      341      -28     
- Misses           0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dahong67
Copy link
Owner Author

dahong67 commented Aug 22, 2024

Not particularly memory-efficient since the slices make copies. Alternatively, could define this in terms of swaps, analogous to: https://github.com/JuliaLang/julia/blob/99d1d6723d72d43074b5d2765e63d08439989e8e/base/combinatorics.jl#L66-L95

That said, good enough for now - merging! Tracking the possible improvement in #6

@dahong67 dahong67 merged commit 51834fc into master Aug 22, 2024
10 checks passed
@dahong67 dahong67 deleted the permutecomps branch August 22, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant