Marlin v1 ultimaker rc3 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on MOTHERBOARD == 7 ? "Ultimaker" : "Mendel"
… You can now decide to allow/disallow large length of extrusions to be executed. Turning off the protection might be beneficial to those who want to do fast and long reversals.
|
Of course I should've written that in English ;) |
|
Changes look fine to me. A few comments:
|
daid
added a commit
that referenced
this pull request
Mar 26, 2013
Fix step rate bug (especially for retraction)
daid
added a commit
that referenced
this pull request
Dec 11, 2013
Fix step rate bug (especially for retraction)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey David,
Ik probeer mijn aanpassingen netjes in git te zetten zodat het wat transparanter is wat voor versie 'stock' is en makkelijker dan een zipfile op firmware.ultimaker.com.
Deze commits lijken me niet te ingrijpend. Als jij het de goede richting in vind gaat, graag mergen en mee upstream laten gaan. Ik heb gerebased en de commits zouden mooi moeten kunnen mergen.
groet,
Erik