Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #38

Open
wants to merge 1 commit into
base: react-native-daily-js-releases
Choose a base branch
from

Conversation

moulie415
Copy link
Contributor

Passing false as an audio or video source is valid so should be reflected in the types

@filipi87
Copy link
Contributor

Hi @moulie415,

Thanks a lot for fixing this.

This repository is a mirror from our internal one. We have already accepted your fix in our internal repository, and It will be available here once we make our next release of react-native-daily-js.

Until then, I will keep this PR open, but after that, we can close It.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants