feat: add post content updated topic #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capJavert
commented
May 29, 2024
capJavert
requested review from
a team,
rebelchris,
omBratteng,
sshanzel and
nensidosari
and removed request for
a team
|
Opening up for review, but as said I might have to fallback some values due to JSON encode issues. |
omBratteng
reviewed
May 29, 2024
capJavert
force-pushed
the
AS-254-content-updated-topic
branch
from
88763bf
to
5d68b1a
Compare
capJavert
commented
May 31, 2024
rebelchris
approved these changes
Jun 3, 2024
| const articlePost = post as ChangeObject<ArticlePost>; | ||
| const freeformPost = post as ChangeObject<FreeformPost>; | ||
|
|
||
| const contentUpdatedMessage = new ContentUpdatedMessage({ |
There was a problem hiding this comment.
Don't we also need the steps here?
(not sure what we called them)
There was a problem hiding this comment.
what steps, for scraping and content processing?
There was a problem hiding this comment.
Yeah the steps taking in processing that we discussed.
So what steps where already done for a article.
|
Merging to see how it works in production. No subscribers yet so it won't really be used instantly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have an issue with JSON encoding, opened an issue