Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presentation of headings outline affected by heading's inline elements #129

Closed
SarahMagdalena opened this issue Dec 14, 2017 · 1 comment

Comments

@SarahMagdalena
Copy link

SarahMagdalena commented Dec 14, 2017

I just noticed, that the presentation of the headings outline in the report is affected by the heading's inline elements.
For example: The following EPUB from gutenberg.org https://www.gutenberg.org/ebooks/19778 uses <a> elements to link the headings with other content. As a result, the headings are presented as links in the headings outline, but the links don't lead anywhere...

ace_outline

Probably most EPUBs don't have any Inline-Elements, but maybe it's still useful to make sure the outlines are shown uniformly?

@rdeltour
Copy link
Member

Thanks, good catch!

@rdeltour rdeltour added this to the v0.8.0 “Beta 4” milestone Dec 14, 2017
@rdeltour rdeltour self-assigned this Dec 19, 2017
rdeltour added a commit that referenced this issue Dec 21, 2017
The headings extraction script now returns the elements `textContent` property
instead of their `innerHTML`.

A smarter processing could be devised in a future version:
- detect an empty content and report a dummy text
- trim long content

Fixes #129
rdeltour added a commit that referenced this issue Dec 21, 2017
The headings extraction script now returns the elements `textContent` property
instead of their `innerHTML`.

A smarter processing could be devised in a future version:
- detect an empty content and report a dummy text
- trim long content

Fixes #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants