Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aXe to v2.6.1 #149

Merged
merged 4 commits into from
Jan 18, 2018
Merged

Update aXe to v2.6.1 #149

merged 4 commits into from
Jan 18, 2018

Conversation

rdeltour
Copy link
Member

Fixes a couple issues related to changes from v2.5 to v2.6:

This PR also uses a tilde range to prevent this issue from happening again, and removes monkey patches made obsolete by aXe 2.6.

@rdeltour rdeltour self-assigned this Jan 10, 2018
@rdeltour rdeltour added this to the v0.9.0 milestone Jan 10, 2018
@rdeltour
feat(aXe): update aXe version to 2.6.1
f382b3c 
Also, use a [tilde range](https://docs.npmjs.com/misc/semver#tilde-ranges-123-12-1)
to avoid being impacted by rule behavior changes.

Fixes #148
@rdeltour
fix(rule): disable aXe check requiring at least one main
eb79b2b 
aXe 2.6.0 introduces a check ensuring that a document has at least
one `main` landmark, in the `landmark-one-main` rule.
Ace disables this check, as it makes no real sense in EPUB.

Fixes #139
@rdeltour
fix(rule): ensure DPUB ARIA roles are accepted by aXe 2.6
508f6b4 
aXe’s internal API, that Ace monkey patches to register DPUB ARIA Roles,
changed from 2.5 to 2.6.

This commit updates the monkey patch to make it applicable to aXe 2.6.x.

Fixes #140
@rdeltour
refactor(aXe): remove obsolete monkey patches
016a3c0 
aXe 2.6.x fixes a couple issues that make a couple monkey patches
obsolete:

- issue with `getSelector` on XHTML (see #57)
- issue with `dl` content model (see #114)
@rdeltour rdeltour merged commit 016a3c0 into master Jan 18, 2018
@rdeltour rdeltour deleted the fix/axe-update branch January 18, 2018 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rdeltour rdeltour

Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Digital Publishing WAI-ARIA roles not supported Landmark main is back as a violation
1 participant
@rdeltour