Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ISRO logo in images page #110

Closed
2 of 4 tasks
dakshsinghrathore opened this issue Oct 21, 2023 · 6 comments · Fixed by #112
Closed
2 of 4 tasks

BUG: ISRO logo in images page #110

dakshsinghrathore opened this issue Oct 21, 2023 · 6 comments · Fixed by #112
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@dakshsinghrathore
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

On clicking ISRO logo in the images page, its reloading instead of heading to Home page !

screen-recorder-sat-oct-21-2023-13-11-00.webm

Record

  • I agree to follow this project's Code of Conduct
  • I'm a Hacktoberfest'23 contributor
  • I want to work on this issue
@dakshsinghrathore dakshsinghrathore added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 21, 2023
@github-actions
Copy link

Congratulations, @dakshsinghrathore! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and I look forward to work with you to resolve the issue. Keep up the great work!

I will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check my contributing guidelines

@rituraj12797
Copy link
Contributor

i would like to wor on this issue kindly assign it to me

@08Uzair
Copy link

08Uzair commented Oct 21, 2023

I will make the PULL REQUEST as soon as u assigned me the issue

@shubhusion
Copy link
Contributor

shubhusion commented Oct 21, 2023

@dakshsinghrathore kindly assign this to me. Bug Rectified. Waiting for your confirmation to do the PR.

Video Proof

@dakshsinghrathore
Copy link
Owner Author

I will make the PULL REQUEST as soon as u assigned me the issue

@08Uzair Thanks for choosing the issue, assigning you the issue straight away....... it would be lovely if dropped a star and follow on this repo and my profile respectfully ! Happy Coding .🤝

shubhusion added a commit to shubhusion/ISRO-web that referenced this issue Oct 21, 2023
@dakshsinghrathore
Copy link
Owner Author

dakshsinghrathore commented Oct 21, 2023

@shubhusion I highly appreciate your quick response, but this is not a good practice of starting to work on an issue without getting a green flag from the admin ! Kindly follow the best practices ✨ Create the PR, will merge it soon 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants