Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added the feature menu vertical navbar #10

Conversation

ankushtripathii
Copy link
Contributor

This PR Added the new vertical navbar that includes (launches, missions, updates, and careers)

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for dsr-isrowebapp ready!

Name Link
🔨 Latest commit 8dd8593
🔍 Latest deploy log https://app.netlify.com/sites/dsr-isrowebapp/deploys/651bf23098d140000938f64a
😎 Deploy Preview https://deploy-preview-10--dsr-isrowebapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ankushtripathii! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and I appreciate your efforts to improve my project.

I will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check my contributing guidelines

@dakshsinghrathore
Copy link
Owner

@ankushtripathii looks great, but a small change is required i.e CENTER THE UNDERLINE
image

@ankushtripathii
Copy link
Contributor Author

ankushtripathii commented Oct 3, 2023

I think that its a bug because I have not added the underline property this I coded {text-decoration: none}

@dakshsinghrathore dakshsinghrathore merged commit cce5846 into dakshsinghrathore:main Oct 3, 2023
5 checks passed
@dakshsinghrathore
Copy link
Owner

Thanks for contributing @ankushtripathii , stick around as i have some special gifts from my side for the top 3 contributors on my repo, kindly star the repo and a follow on github will be much appreciated !!🙌🏽

Copy link
Owner

@dakshsinghrathore dakshsinghrathore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants