-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daylight Savings Not Showing (when OWM API is not used) #27
Comments
That's interesting, I'm in the UK and don't have this problem so can I ask a few questions...
|
I'm in the UK and I have setup the latitude and longitude as the cords of my hometown. My windows PC is displaying the correct time I have looked in the dev tools and I found this:
edit: checked on safari in IOS and it is also displaying wrong time so its not localized to just my PC |
Thanks, I don't use Windows but in both Linux and Android I get the correct time across Firefox, Chrome and Edge. Unfortunately the error you pasted isn't what I need however. In devtools can you open the network tab and copy the response from I can use this to try to reproduce your problem, it should help me to understand what differences there might be between us. |
Also are you using the latest release? Docker container or manually installed? |
I think I have fixed the issue. The problem was that I didn't use an open weather map API key. I didn't think it would need one for the time. I added the environment variable in docker and its now working |
Interesting, thanks for getting back to me. Adding the API key will make Jump use the open weather API, the time will be shown for the location provided by the LATLONG parameter, this essentially takes the current UTC time and applies the shift in seconds for the requested location's timezone. Supplying a value for LATLONG effectively does nothing without having an API key supplied. What I think is happening is that without using the open weather API, Jump actually just displays UTC time rather than applying the local client timezone. I think I should probably explain this more clearly in the readme, also I can fix the case where the open weather API is not used so time is displayed in the client timezone rather than just showing UTC. |
FYI I have included a patch to resolve this, if you pull the latest commits in the main branch you'll see it. It will be included in the next release which I will hopefully push to docker hub later this evening. |
I've created a new release and tag for v1.1.4 and pushed a new image to docker hub, I hope this works OK for you :) |
Yep, Now works without OWM API Key |
Awesome, thanks for letting me know. |
Issue with daylight savings
The clock in the lower right hand corner shows GMT instead of BST
The text was updated successfully, but these errors were encountered: