Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Does Not Install When Using Node 4.x #12

Closed
wrumsby opened this issue Nov 4, 2015 · 2 comments
Closed

Driver Does Not Install When Using Node 4.x #12

wrumsby opened this issue Nov 4, 2015 · 2 comments

Comments

@wrumsby
Copy link
Member

wrumsby commented Nov 4, 2015

Version 0.0.4 does not install when using Node 4.x.

If I have a project that depends on dalek-browser-phantomjs and try to install using npm install (assuming an empty node_modules folder) the installation hangs after

Copying extracted folder...

is logged to the console.

The issue seems to be that the version of Medium/phantomjs being used (1.9.12) depends on a version of ncp that does not work on Node 4.x because of AvianFlu/ncp#79, i.e. if I change the version of ncp used by phantomjs from ~1.0.1 to ~2.0.0 and manually run phantomjs' install.js the installation now works.

Potentially this driver could update to a newer version of phantomjs as versions from 1.9.14 up do not depend on ncp and should support Node 4.x.

@wrumsby
Copy link
Member Author

wrumsby commented Nov 4, 2015

Also adding a link to nodejs/node#2798

@wrumsby
Copy link
Member Author

wrumsby commented Nov 4, 2015

This should actually be fixed by #10 (although the dependency could be expressed as ~1.9.14 instead of 1.9.x), but we would need a new release and a new version published to npm.

wrumsby added a commit to wrumsby/dalek-browser-phantomjs that referenced this issue Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant