Hot-fix coming through! #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damben just tested this out and still getting absolutely no sensor data :/ |
|
Arghh okay hang on getting it sorted. |
|
In the meantime, can somebody open up an issue for a local backup? I should be able to sort it out but just want to get this stuff ready! |
|
@Megan-Wright Can you try this one for now and let me know? |
|
@dambem still nothing :( |
|
It had turned out they deleted them temporarily, this works for me, just needs a little time to allow them to pop through opendata-stuttgart/meta#148 |
Megan-Wright
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue
So, let's talk a little bit about what I did.
Basically, here's the deal. The URL changed from luftdaten to Archive.sensor.community, which is also on a faster server and should now work a lot smoother! Brilliant, everything's great isn't it, all lovely and nothings broken.
Well no. So what was happening on my end was the front-end kept breaking. I couldn't understand why, and I thought oh it must be due to the new website having too much data. Nope. Javascript is actually really good at parsing this data it turns out. What I had done was begin implementing some fun changes in this branch. One of those changes consisted of a fractional reducer. Essentially what it would do is reduce the human_display to show the smallest possible fraction. (e.g, if 10 out of 100 people would die due to pollution, it would reduce it to 1/10)
However, it's been a very nice day over the past 24 hours, so what happened was that 0.96 people out of 500 would die due to pollution. This was not a number that the fractional reducer for some reason can deal with, and decided to blow up in my face, as it couldn't reduce that fraction to whole numbers.
Basically, it's fixed don't worry about it accept this, merge it and move on.
Description of this PR
Checklist