Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getUrlParameter's handling of fragment response #1359

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Fix getUrlParameter's handling of fragment response #1359

merged 4 commits into from
Jan 17, 2022

Conversation

Samuel-B-D
Copy link
Contributor

@Samuel-B-D Samuel-B-D commented Jan 17, 2022 •
edited
Loading

This fixes #1346

@Samuel-B-D
Copy link
Contributor Author

I think a test for square bracket correct handling should also be there for getUrlParameter but I am unsure if you would accept it within this PR or if it should be done in another one.

A test for handling of [] url parameters seems justified since it's an edge-case which required particular handling in the current implementation, and must be upheld if the implementation were to change.

@damienbod damienbod merged commit ffd88d4 into damienbod:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: First fragment parameter is ignored
2 participants
@Samuel-B-D @damienbod