fix(ng-add): remove double quotes in info messages #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
commented
Apr 7, 2022
| @@ -27,8 +27,7 @@ export const httpLoaderFactory = (httpClient: HttpClient) => { | |||
| // autoUserInfo: false, | |||
| }; | |||
| }) | |||
| ) | |||
| .toPromise(); | |||
There was a problem hiding this comment.
Removed because toPromise is deprecated, and more important, StsConfigHttpLoader now only accepts an Observable.
FabianGosebrink
approved these changes
Apr 8, 2022
|
LGTM! Thanks @timdeschryver ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get enough, so I installed the package in another project.
In the process I saw that the info messages from the ng-add command included two double quotes.