-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix throwing config event #1494
Fix throwing config event #1494
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-hill-002425310-1494.centralus.azurestaticapps.net |
|
||
return of(usedConfig); | ||
return configuration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type is changed, will this not effect methods using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type did not change, because this is a new private method. The return type of the public method remains the same.
return of(usedConfig); | ||
} | ||
|
||
private addWellKnownEndpoint(configuration: OpenIdConfiguration): OpenIdConfiguration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name can be improved? It is not just add I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved the name
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-hill-002425310-1494.centralus.azurestaticapps.net |
thanks! |
#1482