feat: add functional interceptor #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
commented
Nov 26, 2022
projects/angular-auth-oidc-client/src/lib/interceptor/auth.interceptor.ts
Show resolved
Hide resolved
projects/angular-auth-oidc-client/src/lib/interceptor/auth.interceptor.spec.ts
Outdated
Show resolved
Hide resolved
timdeschryver
force-pushed
the
feat/functionial-interceptor
branch
from
7f56376
to
384fbc8
Compare
|
LGTM, would love @FabianGosebrink opinion. |
FabianGosebrink
approved these changes
Nov 27, 2022
projects/angular-auth-oidc-client/src/lib/interceptor/auth.interceptor.ts
Show resolved
Hide resolved
|
LGTM as well, thanks @timdeschryver . This is the interceptor, we have to support the providers in a method as well so that users can use this lib without modules. But this can be another PR. The PR fails with A14 with a *.d.ts method. Any ideas why this is happening? Thanks :) |
|
That's probably because it's a v15 type. Thanks for the reviews! |
|
Thank YOU for your work on this! We have to support A14 as well 😑 |
timdeschryver
force-pushed
the
feat/functionial-interceptor
branch
from
ab25b6a
to
f8de810
Compare
timdeschryver
force-pushed
the
feat/functionial-interceptor
branch
from
f8de810
to
7852ba4
Compare
|
Pfew, it took a bit longer than expected 😅 |
|
You are incredible. Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a functional auth interceptor, so it can be used with the new standalone API.
Part of #1599