Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding provided in root to services #1665

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

FabianGosebrink
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-hill-002425310-1665.centralus.azurestaticapps.net

@FabianGosebrink
Copy link
Collaborator Author

@timdeschryver do you see any bugs when we provide every service with providedin: root? What do you think of this PR?

@timdeschryver
Copy link
Contributor

@FabianGosebrink When I was adding the standalone functions, I was also think about this.
I think this can be done, we did something similar while introducing the standalone functions in NgRx.

@FabianGosebrink
Copy link
Collaborator Author

Thanks for your quick reply @timdeschryver :)

@FabianGosebrink FabianGosebrink merged commit 501d0fe into main Jan 31, 2023
@damienbod damienbod deleted the fabiangosebrink/adding-provided-in-root branch April 15, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants