Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added localstorage service. refactored missed jsdocs + fixed imports #1666

Merged
merged 3 commits into from
Jan 30, 2023
Merged

added localstorage service. refactored missed jsdocs + fixed imports #1666

merged 3 commits into from
Jan 30, 2023

Conversation

TarasKovalenko
Copy link
Contributor

@TarasKovalenko TarasKovalenko commented Jan 30, 2023 •
edited
Loading

partially related to this issue:
#827

@damienbod
Copy link
Owner

LGTM, thanks

@TarasKovalenko
Copy link
Contributor Author

LGTM, thanks

thank you for the amazing library :)

@FabianGosebrink FabianGosebrink merged commit 556ec16 into damienbod:main Jan 30, 2023
@FabianGosebrink
Copy link
Collaborator

Thank you very much for your contribution! We really appreciate it and this lib gets better and better because of you! Thank you!!!

@FabianGosebrink
Copy link
Collaborator

Btw: can you link the issue this PR is solving?

@TarasKovalenko
Copy link
Contributor Author

Btw: can you link the issue this PR is solving?

we don't have any active issues for this specific PR, I just saw many questions about localstorage implementation and why the app did log out after the user close the browser tab, and that's why I did this PR.

@FabianGosebrink
Copy link
Collaborator

FabianGosebrink commented Jan 30, 2023 •
edited
Loading

Ah nice, thanks. Can you link some questions then? Then we can make visible that a PR is coming :)

@TarasKovalenko
Copy link
Contributor Author

Ah nice, thanks. Can you link some questions then? Then we can make visible that a PR is coming :)

added a link for the partially related issue to the PR description.

TarasKovalenko added a commit to TarasKovalenko/angular-auth-oidc-client that referenced this pull request Jan 30, 2023
@TarasKovalenko
Merge pull request #2 from damienbod/main
d659cae 
Merge pull request damienbod#1666 from TarasKovalenko/Taras/localstorage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianGosebrink FabianGosebrink FabianGosebrink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TarasKovalenko @damienbod @FabianGosebrink