Bugfix: Updated URL service isCallbackFromSts
#1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect URI if config says to
… config parameter
|
Anything else needed on this one? :) |
|
Hey, thanks for this PR. I did not see this, yet. Will have a look tomorrow. Thanks!!! |
FabianGosebrink
requested changes
Aug 16, 2024
projects/angular-auth-oidc-client/src/lib/utils/url/url.service.ts
Outdated
Show resolved
Hide resolved
|
Small suggestion for beautifying the code, otherwise this is totally fine. Thank you very much! |
Co-authored-by: Fabian Gosebrink <[email protected]>
|
@FabianGosebrink looks like the "commit suggestion" feature didn't do well here, so I'm fixing locally now. Just a sec :) |
|
@FabianGosebrink @damienbod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to match current URL to the redirect URI when determining whether or not it's a callback.
Fixes #1935
As per the comment in the v16 changes, the default value for
checkRedirectUrlWhenCheckingIfIsCallbackis nowtrue.A pre-push hook for Prettier ran when I pushed my changes, so around 30 of the changed files are a result of that.