Fixed Bug were Dynamic Custom Request Parameters are forgotten after first login or forceRefreshSession when doing a silent renew/refresh #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
FabianGosebrink
approved these changes
Jan 26, 2021
|
Hi @juanp3053 I am testing your PR and it breaks the token endpoint request. Moved your changes to a branch: https://github.com/damienbod/angular-auth-oidc-client/tree/juanp3053/Dynamic-Custom-Request Need to find out why this has problems before we can merge. Greetings Damien |
|
@damienbod I didn't get a notification on this. I will take a look and try testing more. I didn't have any issues but I mostly did my testing using PKCE with refresh tokens |
|
Hey @juanp3053 , easy, no worries. We are thankful for the PR. We would be glad you would fix then we can test again and then we will get this thing going :) Thanks again. 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reports: #911 #912
I have fixed the tests and linting, please let me know if need to change anything else.
Thanks