Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate video effects for nvidia shield #349

Open
damontecres opened this issue Aug 10, 2024 · 1 comment
Open

Investigate video effects for nvidia shield #349

damontecres opened this issue Aug 10, 2024 · 1 comment
Assignees
@damontecres
Labels
bug Something isn't working needs investigation Require more investigation to resolve

Comments

@damontecres
Copy link
Owner

Follow up to #347 & #348

Just doing player.setVideoEffects(listOf()) without any effects causing my nvidia shield to show just a black screen during playback. The emulator & fire tv stick work just fine, so it seems to be device-specific.

I couldn't find anything obvious online and it seems like all of the criteria is met to use that function.
@damontecres damontecres added bug Something isn't working needs investigation Require more investigation to resolve labels Aug 10, 2024
@damontecres damontecres self-assigned this Aug 10, 2024
@damontecres damontecres mentioned this issue Sep 7, 2024
Merged
@damontecres
Copy link
Owner Author

I forgot to link to the bug report on androidx/media: androidx/media#1620

It sounds like it might be specific to the NVIDIA Shield's video implementation.

damontecres added a commit that referenced this issue Sep 7, 2024
@damontecres
Move video filters out of experimental (#404)
8cc11b0 
Separate enabling video filters from experimental features. It works
great on supported devices.

When enabling it, users must confirm a dialog so they are aware some
devices aren't supported.

Ref: #349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damontecres damontecres

Labels
bug Something isn't working needs investigation Require more investigation to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@damontecres