Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rewrite the app user interface using Jetpack Compose #340

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2a3d0a4
WIP
damontecres Jul 26, 2024
73cd38f
WIP
damontecres Jul 26, 2024
f897982
WIP card improvements
damontecres Jul 26, 2024
25da549
Add basic filter grid
damontecres Jul 27, 2024
577e214
Add saved filter dropdown
damontecres Jul 27, 2024
6c47548
Add items to nav drawer
damontecres Jul 27, 2024
1a006e3
Fix marquee & card padding
damontecres Jul 27, 2024
5618b55
Add video previews to cards
damontecres Jul 27, 2024
ce6f55e
Add image overlays
damontecres Jul 27, 2024
5d7e502
More overlays
damontecres Jul 28, 2024
ca46f06
Add image card
damontecres Jul 28, 2024
632c829
Add the rest of card types
damontecres Jul 28, 2024
8becb86
Add nav for scene details
damontecres Jul 28, 2024
6e004e2
WIP nav w/ existing fragments
damontecres Jul 28, 2024
a5c198d
Generalize marquee
damontecres Jul 28, 2024
4ae485a
Refactor performer activity to use ID
damontecres Jul 28, 2024
1e9f241
Fix marker playback
damontecres Jul 28, 2024
6a84534
Add toggle for compose UI
damontecres Jul 28, 2024
9348de8
Hook up all data types
damontecres Jul 28, 2024
d22e295
Wrap fragments for compose navigation
damontecres Jul 28, 2024
d314531
Refactors cards into files
damontecres Jul 28, 2024
2206a18
Add basic scene details page
damontecres Jul 28, 2024
718aa44
Scale card images better
damontecres Jul 28, 2024
1fac3d8
Allow for override overall light/dark theme
damontecres Jul 29, 2024
0810de7
Adjust layout sizes for home/nav drawer
damontecres Jul 29, 2024
729d9a7
Minor renaming
damontecres Jul 29, 2024
0fd5289
Add tag page
damontecres Jul 29, 2024
de3aa22
Merge branch 'main' into ui/compose
damontecres Jul 29, 2024
46f9e32
Generalize tabbed grid
damontecres Jul 29, 2024
36eb765
Refactor filters so that they don't store generated code
damontecres Jul 30, 2024
efa2b1a
Add View All card to home page rows
damontecres Jul 30, 2024
c5fdf2a
Fix routing
damontecres Jul 30, 2024
d057578
WIP using safe args routes
damontecres Jul 30, 2024
1e20f35
Merge branch 'main' into ui/compose
damontecres Aug 2, 2024
34c0e0d
Some fixes to navigation
damontecres Aug 2, 2024
c8c4b2d
More fixes to navigation
damontecres Aug 3, 2024
449abfc
Launch activities for non-compose data types
damontecres Aug 3, 2024
540db72
Add playback callback
damontecres Aug 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ plugins {
id("kotlin-parcelize")
id("com.apollographql.apollo3") version "3.8.4"
id("kotlin-kapt")
id("com.google.dagger.hilt.android")
kotlin("kapt")
id("androidx.navigation.safeargs.kotlin")
kotlin("plugin.serialization") version "1.9.25"
}

fun getVersionCode(): Int {
Expand Down Expand Up @@ -43,8 +47,12 @@ android {

buildFeatures {
buildConfig = true
compose = true
}
composeOptions {
// https://developer.android.com/jetpack/androidx/releases/compose-kotlin
kotlinCompilerExtensionVersion = "1.5.14"
}

defaultConfig {
applicationId = "com.github.damontecres.stashapp"
minSdk = 23
Expand Down Expand Up @@ -129,12 +137,18 @@ tasks.register<com.github.damontecres.buildsrc.ParseStashStrings>("generateStrin
outputDirectory = File("$buildDir/generated/res/server")
}

// Allow references to generated code
kapt {
correctErrorTypes = true
}

// tasks.preBuild.dependsOn("generateStrings")
tasks.preBuild.dependsOn("generateStrings")

val mediaVersion = "1.3.1"
val glideVersion = "4.16.0"
val acraVersion = "5.11.3"
val navVersion = "2.8.0-beta06"

dependencies {
implementation("androidx.core:core-ktx:1.13.1")
Expand All @@ -143,7 +157,25 @@ dependencies {
implementation("androidx.leanback:leanback-paging:1.1.0-alpha11")
implementation("com.github.bumptech.glide:glide:$glideVersion")
implementation("com.github.bumptech.glide:okhttp3-integration:$glideVersion")
implementation("com.github.bumptech.glide:compose:1.0.0-beta01")
implementation("androidx.leanback:leanback-tab:1.1.0-beta01")
implementation("androidx.navigation:navigation-runtime-ktx:$navVersion")
implementation("androidx.compose.runtime:runtime-android:1.6.8")
implementation("androidx.navigation:navigation-compose:$navVersion")
implementation("androidx.navigation:navigation-fragment-ktx:$navVersion")
implementation(platform("androidx.compose:compose-bom:2024.06.00"))
implementation("androidx.activity:activity-compose:1.9.1")
implementation("androidx.compose.ui:ui:1.6.8")
implementation("androidx.compose.ui:ui-tooling-preview:1.6.8")
implementation("androidx.compose.material3:material3-android:1.2.1")
debugImplementation("androidx.compose.ui:ui-tooling")
implementation("androidx.tv:tv-foundation:1.0.0-alpha11")
implementation("androidx.tv:tv-material:1.0.0-rc01")
implementation("androidx.compose.ui:ui-viewbinding:1.7.0-beta06")
implementation("androidx.paging:paging-runtime-ktx:3.3.1")
implementation("androidx.paging:paging-compose:3.3.1")
implementation("androidx.compose.runtime:runtime-livedata:1.6.8")
implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.8.4")
implementation("androidx.test.ext:junit-ktx:1.2.1")
kapt("com.github.bumptech.glide:compiler:$glideVersion")
implementation("com.caverock:androidsvg-aar:1.4")
Expand All @@ -165,8 +197,11 @@ dependencies {
implementation("androidx.constraintlayout:constraintlayout:2.1.4")
implementation("androidx.lifecycle:lifecycle-process:2.8.3")
implementation("com.otaliastudios:zoomlayout:1.9.0")
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.1")
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3")
implementation("io.noties.markwon:core:4.6.2")
implementation("com.google.dagger:hilt-android:2.51.1")
implementation("androidx.hilt:hilt-navigation-compose:1.2.0")
kapt("com.google.dagger:hilt-android-compiler:2.51.1")

implementation("ch.acra:acra-http:$acraVersion")
implementation("ch.acra:acra-dialog:$acraVersion")
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@
android:exported="true"
android:icon="@mipmap/stash_logo"
android:logo="@mipmap/stash_logo"
android:noHistory="true"
android:screenOrientation="landscape"
android:theme="@style/NoTitleTheme">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
Expand All @@ -49,6 +47,10 @@
android:name=".MainActivity"
android:exported="false"
android:launchMode="singleTop" />
<activity
android:name=".MainComposeActivity"
android:exported="false"
android:launchMode="singleTop" />
<activity
android:name=".SceneDetailsActivity"
android:exported="false"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,9 @@ class FilterListActivity : FragmentActivity() {
FilterType.APP_FILTER -> {
intent.getParcelableExtra("filter")
}
FilterType.DEFAULT_FILTER -> {
throw IllegalStateException()
}
}
setupFragment(filterData, true)
} else {
Expand Down
117 changes: 64 additions & 53 deletions app/src/main/java/com/github/damontecres/stashapp/GalleryActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import com.github.damontecres.stashapp.util.StashCoroutineExceptionHandler
import com.github.damontecres.stashapp.util.StashGlide
import com.github.damontecres.stashapp.util.TagComparator
import com.github.damontecres.stashapp.util.getInt
import com.github.damontecres.stashapp.util.isNavHostActive
import com.github.damontecres.stashapp.util.isNotNullOrBlank
import com.github.damontecres.stashapp.util.name
import com.github.damontecres.stashapp.util.onlyScrollIfNeeded
Expand All @@ -53,7 +54,6 @@ class GalleryActivity : FragmentActivity() {
setContentView(R.layout.activity_gallery)
if (savedInstanceState == null) {
val galleryId = intent.getStringExtra(INTENT_GALLERY_ID)!!
val galleryName = intent.getStringExtra(INTENT_GALLERY_NAME)

val cardSize =
PreferenceManager.getDefaultSharedPreferences(this)
Expand All @@ -73,10 +73,15 @@ class GalleryActivity : FragmentActivity() {
tabLayout.nextFocusDownId = R.id.gallery_view_pager
tabLayout.children.forEach { it.nextFocusDownId = R.id.gallery_view_pager }
tabLayout.children.first().requestFocus()

supportFragmentManager.beginTransaction()
.replace(R.id.gallery_details, GalleryFragment(gallery))
.commitNow()
if (isNavHostActive()) {
supportFragmentManager.beginTransaction()
.replace(R.id.gallery_details, NavFragment(GalleryFragment(gallery)))
.commitNow()
} else {
supportFragmentManager.beginTransaction()
.replace(R.id.gallery_details, GalleryFragment(gallery))
.commitNow()
}
}
}
}
Expand All @@ -100,14 +105,39 @@ class GalleryActivity : FragmentActivity() {
}

override fun getItem(position: Int): Fragment {
return when (position) {
0 -> {
val fragment =
val createdFragment =
when (position) {
0 -> {
val fragment =
StashGridFragment(
ImageComparator,
ImageDataSupplier(
DataType.IMAGE.asDefaultFindFilterType,
ImageFilterType(
galleries =
Optional.present(
MultiCriterionInput(
value = Optional.present(listOf(gallery.id)),
modifier = CriterionModifier.INCLUDES_ALL,
),
),
),
),
getColumns(DataType.IMAGE),
)
fragment.onItemViewClickedListener =
ImageGridClickedListener(this@GalleryActivity, fragment) {
it.putExtra(ImageActivity.INTENT_GALLERY_ID, gallery.id)
}
fragment
}

1 ->
StashGridFragment(
ImageComparator,
ImageDataSupplier(
DataType.IMAGE.asDefaultFindFilterType,
ImageFilterType(
SceneComparator,
SceneDataSupplier(
DataType.SCENE.asDefaultFindFilterType,
SceneFilterType(
galleries =
Optional.present(
MultiCriterionInput(
Expand All @@ -117,47 +147,29 @@ class GalleryActivity : FragmentActivity() {
),
),
),
getColumns(DataType.IMAGE),
getColumns(DataType.SCENE),
)

2 ->
StashGridFragment(
PerformerComparator,
GalleryPerformerDataSupplier(gallery),
getColumns(DataType.PERFORMER),
)
fragment.onItemViewClickedListener =
ImageGridClickedListener(this@GalleryActivity, fragment) {
it.putExtra(ImageActivity.INTENT_GALLERY_ID, gallery.id)
}
fragment

3 ->
StashGridFragment(
TagComparator,
GalleryTagDataSupplier(gallery),
getColumns(DataType.TAG),
)

else -> throw IllegalArgumentException()
}
1 ->
StashGridFragment(
SceneComparator,
SceneDataSupplier(
DataType.SCENE.asDefaultFindFilterType,
SceneFilterType(
galleries =
Optional.present(
MultiCriterionInput(
value = Optional.present(listOf(gallery.id)),
modifier = CriterionModifier.INCLUDES_ALL,
),
),
),
),
getColumns(DataType.SCENE),
)

2 ->
StashGridFragment(
PerformerComparator,
GalleryPerformerDataSupplier(gallery),
getColumns(DataType.PERFORMER),
)

3 ->
StashGridFragment(
TagComparator,
GalleryTagDataSupplier(gallery),
getColumns(DataType.TAG),
)

else -> throw IllegalArgumentException()
return if (isNavHostActive()) {
NavFragment(createdFragment)
} else {
createdFragment
}
}
}
Expand Down Expand Up @@ -274,7 +286,6 @@ class GalleryActivity : FragmentActivity() {
}

companion object {
const val INTENT_GALLERY_ID = "gallery.id"
const val INTENT_GALLERY_NAME = "gallery.name"
const val INTENT_GALLERY_ID = "id"
}
}
30 changes: 23 additions & 7 deletions app/src/main/java/com/github/damontecres/stashapp/ImageActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import com.github.damontecres.stashapp.util.concatIfNotBlank
import com.github.damontecres.stashapp.util.height
import com.github.damontecres.stashapp.util.isGif
import com.github.damontecres.stashapp.util.isImageClip
import com.github.damontecres.stashapp.util.isNavHostActive
import com.github.damontecres.stashapp.util.maxFileSize
import com.github.damontecres.stashapp.util.showSetRatingToast
import com.github.damontecres.stashapp.util.toFindFilterType
Expand Down Expand Up @@ -88,9 +89,15 @@ class ImageActivity : FragmentActivity() {
} else {
ImageFragment(image)
}
supportFragmentManager.beginTransaction()
.replace(R.id.image_fragment, imageFragment as Fragment)
.commitNow()
if (isNavHostActive()) {
supportFragmentManager.beginTransaction()
.replace(R.id.image_fragment, NavFragment(imageFragment as Fragment))
.commitNow()
} else {
supportFragmentManager.beginTransaction()
.replace(R.id.image_fragment, imageFragment as Fragment)
.commitNow()
}

val pageSize =
PreferenceManager.getDefaultSharedPreferences(this@ImageActivity)
Expand Down Expand Up @@ -231,9 +238,18 @@ class ImageActivity : FragmentActivity() {
} else {
ImageFragment(image)
}
supportFragmentManager.beginTransaction()
.replace(R.id.image_fragment, imageFragment as Fragment)
.commitNow()
if (isNavHostActive()) {
supportFragmentManager.beginTransaction()
.replace(
R.id.image_fragment,
NavFragment(imageFragment as Fragment),
)
.commitNow()
} else {
supportFragmentManager.beginTransaction()
.replace(R.id.image_fragment, imageFragment as Fragment)
.commitNow()
}
} else if (image == null) {
Toast.makeText(this@ImageActivity, "No more images", Toast.LENGTH_SHORT)
.show()
Expand All @@ -247,7 +263,7 @@ class ImageActivity : FragmentActivity() {

companion object {
const val TAG = "ImageActivity"
const val INTENT_IMAGE_ID = "image.id"
const val INTENT_IMAGE_ID = "id"
const val INTENT_IMAGE_URL = "image.url"
const val INTENT_IMAGE_SIZE = "image.size"

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package com.github.damontecres.stashapp

import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.RectangleShape
import androidx.core.view.WindowCompat
import androidx.tv.material3.Surface
import com.github.damontecres.stashapp.ui.App
import com.github.damontecres.stashapp.ui.theme.AppTheme
import dagger.hilt.android.AndroidEntryPoint

@AndroidEntryPoint
class MainComposeActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
WindowCompat.setDecorFitsSystemWindows(window, false)
setContent {
AppTheme {
Surface(
shape = RectangleShape,
modifier = Modifier.fillMaxSize(),
) {
App()
}
}
}
}
}
Loading
Loading