Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new filters for Scenes in the app #420

Merged
merged 33 commits into from
Sep 20, 2024
Merged

Create new filters for Scenes in the app #420

merged 33 commits into from
Sep 20, 2024

Conversation

damontecres
Copy link
Owner

@damontecres damontecres commented Sep 16, 2024 •
edited
Loading

Related to #178

Adds ability to create a filter for scenes and optionally & experimentally save it to the server. Can start with a blank filter or build up from the currently selected saved filter.

Note: saving to the server requires enabling experiment features in advanced settings since it is not fully tested

This has several limitations:

  • Only supports scene filters right now
  • Only a limited subset of available filter options
  • UI/UX is okay, but not great
  • It takes many clicks to configure things
  • Lots of hand written code AKA possibly error prone

@damontecres damontecres added enhancement New feature or request user interface Relates to the app's user interface/experience labels Sep 16, 2024
@damontecres damontecres changed the title Filter data on demand Create (and save) filters for Scenes in the app Sep 17, 2024
@damontecres damontecres changed the title Create (and save) filters for Scenes in the app Create filters for Scenes in the app Sep 20, 2024
@damontecres damontecres marked this pull request as ready for review September 20, 2024 22:55
@damontecres damontecres changed the title Create filters for Scenes in the app Create new filters for Scenes in the app Sep 20, 2024
@damontecres damontecres merged commit e5a8dc9 into main Sep 20, 2024
2 checks passed
@damontecres damontecres deleted the ui/create-filter branch September 20, 2024 23:55
@damontecres damontecres mentioned this pull request Sep 23, 2024
Merged
damontecres added a commit that referenced this pull request Sep 24, 2024
@damontecres
Create filters for all data types (#421)
0538d0f 
Follow up to #420 to add ability to create filters for all data types

Like with scenes, not every single option is available for every data
type.

Also adds between filtering for ints & floats.
@damontecres damontecres mentioned this pull request Sep 27, 2024
Merged
damontecres added a commit that referenced this pull request Sep 27, 2024
@damontecres
Several UI/UX updates for creating filters (#425)
8288248 
Follow up to #420 & #421

1. Actually use the rating picker for rating filters
2. Update the filter descriptions as they are set
3. Fix a few filter descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request user interface Relates to the app's user interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@damontecres