Skip to content

Commit

Permalink
permissions: Update camera usage string to be more accurate
Browse files Browse the repository at this point in the history
This changes the text that appears on the camera permission dialog, and makes it clear that camera access is also needed for the scanning of QR codes. This change was made to address a concern raised during the Apple app review process.

Testing
-------

PASS

Device: iPhone 13 Mini (physical)
iOS: 17.1
Damus: This commit
Special remarks: I locally modified the bundle identifier to be able to install a fresh copy of Damus from scratch and go through the prompt, without having to uninstall my own copy of Damus

Steps:
1. Install a fresh copy of Damus
2. On account creation, try to scan an nsec.
3. Make sure the camera usage prompt message is modified to the new string.

Signed-off-by: Daniel D’Aquino <[email protected]>
Reviewed-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
  • Loading branch information
danieldaquino authored and jb55 committed Nov 12, 2023
1 parent b2e5552 commit 386a284
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion damus/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<true/>
</dict>
<key>NSCameraUsageDescription</key>
<string>Damus needs access to your camera for creating photo posts</string>
<string>Damus needs access to your camera in order to upload photos and scan QR codes.</string>
<key>NSAppleMusicUsageDescription</key>
<string>Damus needs access to your media library for playback statuses</string>
<key>NSMicrophoneUsageDescription</key>
Expand Down

0 comments on commit 386a284

Please sign in to comment.