fix: take parentNode scrollHeight into account when using non-window scroller #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoslin
force-pushed
the
non-window-scroll
branch
from
e904e15
to
0a17028
Compare
ajoslin
changed the title
ajoslin
force-pushed
the
non-window-scroll
branch
from
0a17028
to
e3b456c
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the calculation is wrong when using a parentNode scroller. It takes the component element's scrollHeight into account instead of the scroller's.
This patch amends that.
Math Example:
Scroll viewport:
In this case, to get a proper offset we need to calculate
1000 - 667 - 100to the real offset of233, which should cause a new scroll load (assuming default threshold).