Tests: 🐇 bunny reading results

[dancergraham]

Test that the extents (max - min coordinates) of the bunny pointcloud are close to
Box dimensions
X: 0.155698
Y: 0.14731
Z: 0.120672

Global box center (median position)
X: -0.016840
Y: 0.113666
Z: -0.001537

[devdanzin]

The test for box dimensions is passing, but the one for box center fails:

def test_global_box_center():
    pointcloud: np.ndarray = e57.read_points(r"testdata/bunnyFloat.e57")
    X, Y, Z = np.median(pointcloud, 0)
    assert X == pytest.approx(-0.016840)
    assert Y == pytest.approx(0.113666)
    assert Z == pytest.approx(-0.001537)

We actually get
X: -0.032498
Y: 0.101142
Z: 0.00749

Please assess my numpy code in the test, I'm not good at it and might be getting the wrong median. What else can be the issue here?

[dancergraham]

Hello, ahh yes it is not really the median but rather the max plus the min divided by two ! Sorry wrong wording from me!

[dancergraham]

The code looks good - I didn't know about pytest.approx. I have always used numpy.isclose but approx is a little cleaner !