Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Can't disable line-numbers in a custom feature #446

Open
dandavison opened this issue Dec 14, 2020 · 0 comments
Open

🐛 Can't disable line-numbers in a custom feature #446

dandavison opened this issue Dec 14, 2020 · 0 comments

Comments

@dandavison
Copy link
Owner

cc @ulwlu @HaleTom ref #307 #340 (comment)

I feel that this should work, but it does not:

[delta]
    line-numbers = true
    features = no-line-numbers

[delta "no-line-numbers"]
    line-numbers = false

Debugging suggests that it may involve delta refusing to visit the line-numbers entry twice:

[src/options/set.rs:393] &features = [
    "line-numbers",
    "no-line-numbers",
]

Perhaps however it should notice that the second entry was associated with a different value from the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant