Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 DELTA_FEATURES env var should add to other features, not replace them #848

Closed
dandavison opened this issue Dec 11, 2021 · 2 comments · Fixed by #849
Closed

🐛 DELTA_FEATURES env var should add to other features, not replace them #848

dandavison opened this issue Dec 11, 2021 · 2 comments · Fixed by #849

Comments

@dandavison
Copy link
Owner

I think it would be more useful if DELTA_FEATURES added to features specified in git config, rather than replacing them as it does today. For example, this would make it more convenient as a way to toggle side-by-side mode. I'm thinking that if a user does need to deactivate the features in git config they have --no-gitconfig.
dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
Add features from DELTA_FEATURES env var instead of replacing with them
68f137b 
Fixes #848
@dandavison dandavison mentioned this issue Dec 12, 2021
Merged
@bew
Copy link

bew commented Dec 12, 2021

What about requiring that env var to start with + to mean append?
This way it can do both

dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
Add features from DELTA_FEATURES env var instead of replacing with them
1a9d607 
Fixes #848
dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
Add features from DELTA_FEATURES env var instead of replacing with them
78ffcd3 
Fixes #848
@dandavison
Copy link
Owner Author

What about requiring that env var to start with + to mean append?

OK, I can do that, thanks for the suggestion!

dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
DELTA_FEATURES appends iff prefixed with +
92fd1e4 
Thanks @bew for the suggestion.

Fixes #848
dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
DELTA_FEATURES appends iff prefixed with +
ba3359f 
Thanks @bew for the suggestion.

Fixes #848
dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
DELTA_FEATURES appends iff prefixed with +
fab41c3 
Thanks @bew for the suggestion.

Fixes #848
dandavison added a commit that referenced this issue Dec 12, 2021
@dandavison
DELTA_FEATURES appends iff prefixed with +
fbf88e4 
Thanks @bew for the suggestion.

Fixes #848
@dandavison dandavison mentioned this issue Jun 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add features from DELTA_FEATURES env var instead of replacing with them dandavison/delta
2 participants
@dandavison @bew