Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reregisterurl to move datalad remotes to web #36

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Use reregisterurl to move datalad remotes to web #36

merged 1 commit into from
Jul 26, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 7, 2024

Closes #35.

@jwodder jwodder added blocked Cannot be implemented until something else happens embargo Handling embargoed Dandisets & assets on the Archive labels Mar 7, 2024
@jwodder
Copy link
Member Author

jwodder commented May 22, 2024

Now blocked by the fact that this requires git-annex 10.20240430 but neurodebian still only has 10.20240227.

CC @yarikoptic

@jwodder
Copy link
Member Author

jwodder commented May 22, 2024

Correction: While the outdated git-annex is a problem, the current test failures are actually due to dandi/dandi-archive#1943.

@yarikoptic
Copy link
Member

on neurodebian and drogon we have now 10.20240430-1~ndall+1 but within dandisets-2 conda env we are using conda installed git-annex and there we have not seen updates for quite a while :-/ need to see if I could figure it out conda-forge/git-annex-feedstock#160 . any ideas/help is most welcome!

@yarikoptic
Copy link
Member

I removed git and git-annex packages in that conda env (dandisets-2) so we should be ready to merge/deploy this to prevent datasets failing their updates.

Note that it seems that subsequent update on the failed dataset just proceeds forward, so we might need to get back to those which once were private and migrate "retroactively" -- please add some support command or script for doing that.

@jwodder
Copy link
Member Author

jwodder commented Jun 7, 2024

@yarikoptic This can't be merged, as the tests are still failing due to dandi/dandi-archive#1943.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (99e4daa) to head (125b6d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   73.41%   74.62%   +1.20%     
==========================================
  Files          17       17              
  Lines        2799     2806       +7     
  Branches      623      624       +1     
==========================================
+ Hits         2055     2094      +39     
+ Misses        569      533      -36     
- Partials      175      179       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder removed the blocked Cannot be implemented until something else happens label Jul 22, 2024
@jwodder jwodder marked this pull request as ready for review July 23, 2024 14:51
@jwodder
Copy link
Member Author

jwodder commented Jul 23, 2024

@yarikoptic The tests are finally passing now, and I've created a separate PR in dandi/dandisets for adding a script for backfilling the reregisterurl invocations: dandi/dandisets#387

@yarikoptic
Copy link
Member

Thank you! Let's get it in!

@yarikoptic yarikoptic merged commit 0d1e173 into main Jul 26, 2024
7 checks passed
@yarikoptic yarikoptic deleted the gh-35 branch July 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embargo Handling embargoed Dandisets & assets on the Archive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unembargo: move URLs from "datalad" to "web" remote
2 participants