Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organization as author #1472

Closed
bendichter opened this issue Feb 7, 2023 · 4 comments
Closed

organization as author #1472

bendichter opened this issue Feb 7, 2023 · 4 comments

Comments

@bendichter
Copy link
Member

bendichter commented Feb 7, 2023

In dandiset 149, an attempt was made to list an organization as an author:

image

This caused a validation error in the metadata. The IBL does like to list "International Brain Laboratory" as an author, e.g. here.

If we want to allow this, we should allow it in the schema. If we want to disallow this, we should prevent it in the metadata editor.

@satra
Copy link
Member

satra commented Feb 7, 2023

what is the validation error that you received? is it because the url is not wellformed (https:// missing)?

@bendichter
Copy link
Member Author

@satra

ValidationError: 4 validation errors for Dandiset
contributor -> 0 -> schemaKey
  schemaKey Organization does not match classname Person (type=value_error)
contributor -> 0 -> name
  string does not match regex "^([\w\s\-\.']+),\s+([\w\s\-\.']+)$" (type=value_error.str.regex; pattern=^([\w\s\-\.']+),\s+([\w\s\-\.']+)$)
contributor -> 0 -> url
  invalid or missing URL scheme (type=value_error.url.scheme)
contributor -> 0 -> url
  invalid or missing URL scheme (type=value_error.url.scheme)

image

@satra
Copy link
Member

satra commented Feb 7, 2023

did you try adding https:// for the url?

@bendichter
Copy link
Member Author

@satra ok yes, that was the issue. I find that difficult to decipher from the validation error messages from the API and from the Web UI. The web UI says nothing about URL at all. The validation errors start with two errors that are irrelevant. I suppose fixing #1477 would fix this anyway, so I'll close in favor of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants