Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata editor form allows improper contributor url #1477

Open
bendichter opened this issue Feb 7, 2023 · 4 comments
Open

metadata editor form allows improper contributor url #1477

bendichter opened this issue Feb 7, 2023 · 4 comments
Assignees
@mvandenburgh
Labels
bug Something isn't working client/meditor Issues with the metadata editor (meditor) client Pertains to the web client UX Affects usability of the system
Milestone
Web app usability

Comments

@bendichter
Copy link
Member

bendichter commented Feb 7, 2023 •
edited
Loading

image

This data is allowed by the metadata editor, but fails validation because the url is missing http://. Can we modify the form to validate the URL field and prevent users from entering improper urls?
@bendichter
Copy link
Member Author

To make matters worse, the validation error in the web interface is not very informative

image

This was referenced Feb 7, 2023
Open
Closed
@jjnesbitt jjnesbitt added client Pertains to the web client meditor labels Feb 7, 2023
@satra
Copy link
Member

satra commented Feb 7, 2023

@mvandenburgh - are we using ajv with vjsf? that may help with some of these. i can also look into creating a pyscript runnable version of the schema. since vjsf allows external validators.

@satra satra mentioned this issue Feb 7, 2023
Open
@mvandenburgh
Copy link
Member

mvandenburgh commented Feb 10, 2023 •
edited
Loading

@mvandenburgh - are we using ajv with vjsf? that may help with some of these. i can also look into creating a pyscript runnable version of the schema. since vjsf allows external validators.

No, but vjsf has first-class support for ajv, so we could.

@yarikoptic yarikoptic mentioned this issue Feb 13, 2023
Open
@waxlamp waxlamp added bug Something isn't working UX Affects usability of the system labels Feb 17, 2023
@waxlamp waxlamp added client/meditor Issues with the metadata editor (meditor) and removed meditor labels Feb 28, 2023
@waxlamp waxlamp added this to the Web app usability milestone Mar 1, 2023
@mvandenburgh mvandenburgh mentioned this issue May 22, 2023
Open
@mvandenburgh
Copy link
Member

Opened #1601 to track the AJV integration task explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvandenburgh mvandenburgh

Labels
bug Something isn't working client/meditor Issues with the metadata editor (meditor) client Pertains to the web client UX Affects usability of the system
Projects
None yet
Milestone
Web app usability
Development

No branches or pull requests
5 participants
@satra @bendichter @waxlamp @jjnesbitt @mvandenburgh