Properly handle conflicting asset paths

[jjnesbitt]

Closes #1109

[danlamanna]

Adding reference to #1109.

I think this is a problem with the paths of assets, not asset paths, right 😕? I think the validation should occur outside of asset_paths, ideally in add_asset_to_version next to the duplicate asset path check. Otherwise the asset_paths code is responsible for some portions of asset/version validation in addition to creating a performant data structure for asset lookups. I'm not as familiar with this code though so let me know if I got something wrong.

[jjnesbitt]

I think this is a problem with the paths of assets, not asset paths, right confused? I think the validation should occur outside of asset_paths, ideally in add_asset_to_version next to the duplicate asset path check. Otherwise the asset_paths code is responsible for some portions of asset/version validation in addition to creating a performant data structure for asset lookups. I'm not as familiar with this code though so let me know if I got something wrong.

Good point, I think it probably is best if the error is raised in add_asset_to_version, although I think the best way to perform such a check would be to use the asset paths model, via some utility function.

[dandibot]

🚀 PR was released in v0.3.2 🚀