Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached namespace validation #1149

Merged

Conversation

CodyCBakerPhD
Copy link
Contributor

Fixes #917

Which came from dandi/helpdesk#43

Replaces #1036

Newest version of PyNWB supports validation against cached namespaces (and indeed this is now the default).

I've updated the usage here in a minimal way to both support older PyNWB versions (my other thought was to bump the version in the setup.cfg, but IDK what your policy or view is on that) that do not offer this feature as well as the newest version that supports it as a simple adjustment to the way the pynwb.validate function is called.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 88.27% // Head: 88.25% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d7ab706) compared to base (82b99ca).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
- Coverage   88.27%   88.25%   -0.02%     
==========================================
  Files          73       73              
  Lines        8800     8803       +3     
==========================================
+ Hits         7768     7769       +1     
- Misses       1032     1034       +2     
Flag Coverage Δ
unittests 88.25% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/pynwb_utils.py 82.81% <57.14%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Thank you @CodyCBakerPhD and sorry I've missed it whenever you originally filed it. Looks good to me and is Green (freshier PRs aren't as lucky due to some disturbance in the Force). So I will not delay merging it as is. I think we can stick to not demand upgraded pynwb for a bit longer but might soon as well beef it up.

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Nov 11, 2022
@yarikoptic yarikoptic merged commit 75da4bb into dandi:master Nov 11, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the use_cached_namespace_validation branch November 11, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namespace checks
2 participants